Generate jitdump to support linux perf for LLVM JIT #2788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lum1n0us
force-pushed
the
enable_jitdump
branch
4 times, most recently
from
92a04a1
to
349ad8b
Compare
wenyongh
reviewed
Nov 24, 2023
core/iwasm/include/wasm_export.h
Outdated
| @@ -169,6 +169,14 @@ typedef struct RuntimeInitArgs { | |||
| uint32_t llvm_jit_size_level; | |||
| /* Segue optimization flags for LLVM JIT */ | |||
| uint32_t segue_flags; | |||
| /** | |||
| * If enable | |||
product-mini/platforms/posix/main.c
Outdated
| @@ -99,6 +99,7 @@ print_help() | |||
| #if WASM_ENABLE_STATIC_PGO != 0 | |||
| printf(" --gen-prof-file=<path> Generate LLVM PGO (Profile-Guided Optimization) profile file\n"); | |||
| #endif | |||
| printf(" --perf-profile Enable linux perf support. For now, it only works in llvm-jit.\n"); | |||
There was a problem hiding this comment.
Had better wrap the line with macro: #if WASM_ENABLE_JIT !=0 ... #endif
product-mini/platforms/posix/main.c
Outdated
| @@ -593,6 +594,7 @@ main(int argc, char *argv[]) | |||
| #if WASM_ENABLE_THREAD_MGR != 0 | |||
| int timeout_ms = -1; | |||
| #endif | |||
| bool enable_linux_perf_support = false; | |||
There was a problem hiding this comment.
Same as above, had better wrap the code with macro WASM_ENABLE_JIT
There was a problem hiding this comment.
How about putting this line after L563 uint32 segue_flags = 0;
wenyongh
reviewed
Nov 27, 2023
lum1n0us
force-pushed
the
enable_jitdump
branch
2 times, most recently
from
2476014
to
0af902b
Compare
wenyongh
reviewed
Nov 27, 2023
product-mini/platforms/posix/main.c
Outdated
| @@ -593,6 +594,7 @@ main(int argc, char *argv[]) | |||
| #if WASM_ENABLE_THREAD_MGR != 0 | |||
| int timeout_ms = -1; | |||
| #endif | |||
| bool enable_linux_perf_support = false; | |||
There was a problem hiding this comment.
How about putting this line after L563 uint32 segue_flags = 0;
lum1n0us
force-pushed
the
enable_jitdump
branch
from
0af902b
to
a9ed54b
Compare
wenyongh
reviewed
Nov 27, 2023
lum1n0us
force-pushed
the
enable_jitdump
branch
from
a9ed54b
to
f6d6eb3
Compare
doc/perf_tune.md
Outdated
|
|
||
| ### 7.1 Flamegraph | ||
|
|
||
| [Flamegraph](https://www.brendangregg.com/flamegraphs.html) is a powerful tool to visualize stack traces of profiled software so that the most frequent code-paths to be identified quickly and accurately. In order to use it, you need to record call graphs when running `perf record` |
There was a problem hiding this comment.
to be or can be?
Suggested change
| [Flamegraph](https://www.brendangregg.com/flamegraphs.html) is a powerful tool to visualize stack traces of profiled software so that the most frequent code-paths to be identified quickly and accurately. In order to use it, you need to record call graphs when running `perf record` | |
| [Flamegraph](https://www.brendangregg.com/flamegraphs.html) is a powerful tool to visualize stack traces of profiled software so that the most frequent code-paths can be identified quickly and accurately. In order to use it, you need to record call graphs when running `perf record` |
lum1n0us
force-pushed
the
enable_jitdump
branch
from
f6d6eb3
to
a1b0bb3
Compare
lum1n0us
changed the title
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.