Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unused thread_id warning and recompile multi-module sample #3033

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Avoid unused thread_id warning and recompile multi-module sample #3033

merged 1 commit into from
Jan 17, 2024

Conversation

eloparco
Copy link
Contributor

@eloparco eloparco commented Jan 16, 2024 •
edited
Loading

  • Unused var warning (when building in release mode):
wasm-micro-runtime/samples/wasi-threads/wasm-apps/no_pthread.c:44:9: warning: variable 'thread_id' set but not used [-Wunused-but-set-variable]
    int thread_id;
        ^
1 warning generated.
  • When using the multi-module example and changing the files in wasm-apps, they don't get recompiled when the sample is rebuilt. Adding BUILD_ALWAYS as it's done in other samples.

wenyongh
wenyongh reviewed Jan 16, 2024
View reviewed changes
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit 25ccc9f into bytecodealliance:main Jan 17, 2024
395 checks passed
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
@eloparco
Avoid unused thread_id warning and recompile multi-module sample (byt…
87c6e7a 
…ecodealliance#3033)

- Unused variable warning (when building in release mode):
```bash
wasm-micro-runtime/samples/wasi-threads/wasm-apps/no_pthread.c:44:9:
warning: variable 'thread_id' set but not used [-Wunused-but-set-variable]
    int thread_id;
```
- When using the multi-module example and changing the files in `wasm-apps`,
  they don't get recompiled when the sample is rebuilt. Adding `BUILD_ALWAYS`
  as it's done in other samples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenyongh wenyongh wenyongh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eloparco @wenyongh