-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zero the memory from os_mmap in NuttX #3132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyongh
reviewed
Feb 5, 2024
wenyongh
reviewed
Feb 5, 2024
@@ -161,7 +173,8 @@ os_dcache_flush() | |||
|
|||
void | |||
os_icache_flush(void *start, size_t len) | |||
{} | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not change the code, or CI guideline check will fail.
wenyongh
reviewed
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wenyongh
added a commit
that referenced
this pull request
Feb 17, 2024
Apply patches in branch main for branch `release/1.3.x`: - Fix loader check_wasi_abi_compatibility (#3126) - Zero the memory mapped from os_mmap in NuttX (#3132) - Fix possible integer overflow in loader target block check (#3133) - Fix locel.set in polymorphic stack (#3135) - Fix threads opcodes' boundary check in classic-interp and fast-interp (#3136) - aot_compile_op_call: Stop setting calling convention explicitly (#3140) - aot compiler: Place precheck wrapper before the corresponding wrapped function (#3141) - fast-interp: Fix copy_stack_top_i64 overlap issue (#3146) - fast-interp: Fix frame_offset overflow issue (#3149) - Fix null pointer access in fast-interp when configurable soft bound check is enabled (#3150)
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Zero the memory which is required by os_mmap. This fixes the nuttx spec test CI failure: https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/7777804669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.