Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wasm loader check data segment count #3492

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

wenyongh
Copy link
Contributor

@wenyongh wenyongh commented Jun 3, 2024

When datacount section exists, loader will check whether the data count
read from data segment section is same with the data count read from
datacount section, but the value of latter can be 0, loader should not
skip the check when the latter is 0.

Copy link
Collaborator

@xujuntwt95329 xujuntwt95329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TianlongLiang
Copy link
Contributor

LGTM

@wenyongh wenyongh merged commit 0a80cc4 into bytecodealliance:main Jun 3, 2024
377 checks passed
@wenyongh wenyongh deleted the fix_datacount_compare branch June 4, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants