Add a wasmtime::Linker type
#1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new type to the `wasmtime` crate, a `Linker`. This linker is intended to vastly simplify calling `Instance::new` by easily performing name resolution and incrementally defining state over time. The goal here is to start down a path of making linking wasm modules in `wasmtime` a first-class and ergonomic operation. This is highly likely to evolve over time and get tweaked through releases as we iterate towards a design well-suited for `wasmtime`, but this is intended to at least be the initial foundation for such functionality. This commit additionally also adds a C API for the linker and switches the existing linking examples to using this linker in both Rust and C. One piece of future work I'd like to tackle next is to integrate WASI into the `wasmtime` crate in a more first-class manner. This [`Linker`] type provides a great location to hook into the instantiation process to easily instantiate modules with WASI imports. That's a relatively large refactoring for now though and I figured it'd be best left for a different time. Closes bytecodealliance#727
github-actions
bot
added
wasi
Subscribe to Label ActionThis issue or pull request has been labeled: "wasi", "wasmtime:api", "wasmtime:c-api" Users Subscribed to "wasmtime:api"Users Subscribed to "wasmtime:c-api"To subscribe or unsubscribe from this label, edit the |
peterhuene
reviewed
Mar 23, 2020
There was a problem hiding this comment.
This looks great and I really like how it simplifies things. I like this better than taking a list of instances to Module.Instantiate in the C# API, so I'll create a first-class Linker representation instead.
Just some minor feedback, but otherwise 👍 from me.
|
Updated! |
peterhuene
approved these changes
Mar 23, 2020
sunfishcode
reviewed
Mar 24, 2020
| /// let mut linker = Linker::new(&store); | ||
| /// let ty = GlobalType::new(ValType::I32, Mutability::Const); | ||
| /// let global = Global::new(&store, ty, Val::I32(0x1234))?; | ||
| /// linker.define("host", "offset", global); |
There was a problem hiding this comment.
This should have a ? to handle errors.
There was a problem hiding this comment.
Oh good eye, I've added a commit to #1391 which denies warnings in doctests to catch this
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new type to the
wasmtimecrate, aLinker. Thislinker is intended to vastly simplify calling
Instance::newby easilyperforming name resolution and incrementally defining state over time.
The goal here is to start down a path of making linking wasm modules in
wasmtimea first-class and ergonomic operation. This is highly likelyto evolve over time and get tweaked through releases as we iterate
towards a design well-suited for
wasmtime, but this is intended to atleast be the initial foundation for such functionality.
This commit additionally also adds a C API for the linker and switches
the existing linking examples to using this linker in both Rust and C.
One piece of future work I'd like to tackle next is to integrate WASI
into the
wasmtimecrate in a more first-class manner. This [Linker]type provides a great location to hook into the instantiation process to
easily instantiate modules with WASI imports. That's a relatively large
refactoring for now though and I figured it'd be best left for a
different time.
Closes #727