Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reassociate mixture of add and sub to wide trees #8518

Merged
merged 1 commit into from
May 2, 2024

Conversation

KGrewal1
Copy link
Contributor

@KGrewal1 KGrewal1 commented May 1, 2024

As in #7466 , converts deep nesting of addition and subtraction into a wide tree eg:

$((a-b)-c)-d)=(a-b)-(c+d)$

again using subsume to prevent blow up due to reassociating large chains

@KGrewal1 KGrewal1 requested a review from a team as a code owner May 1, 2024 15:33
@KGrewal1 KGrewal1 requested review from abrown and removed request for a team May 1, 2024 15:34
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language labels May 1, 2024
Copy link

github-actions bot commented May 1, 2024

Subscribe to Label Action

cc @cfallin, @fitzgen

This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

  • cfallin: isle
  • fitzgen: isle

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Contributor

@abrown abrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me but does anyone with ISLE conventions paged in want to comment: @cfallin, @elliottt, @jameysharp?

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@fitzgen fitzgen added this pull request to the merge queue May 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 2, 2024
@fitzgen fitzgen added this pull request to the merge queue May 2, 2024
@fitzgen
Copy link
Member

fitzgen commented May 2, 2024

(Some network issue when installing open-vino in CI; retrying)

Merged via the queue into bytecodealliance:main with commit b7ba20f May 2, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants