wasmtime Config: debug impl now iterates complete WasmFeatures flag set #8843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the wasm_memory64 flag was left out of Config's debug impl, so rather than add it, I decided to use the
bitflags::Flags::FLAGS
const to iterate the complete set of flags.THe downside of this change is that it will print flags which do not have a setter in Config, e.g.
wasm_component_model_nested_names
.An alternative to this change is, rather than expanding out the single
features: WasmFeatures
member into many different debug_struct fields, the debug impl of WasmFeatures is used.Here is a sample debug of Config with this change: