feat(tree): enable label select #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hangweiqiang-uestc
commented
Jul 9, 2021
hangweiqiang-uestc
commented
- support label selection in tree model
- treat '' as 'nan'
hangweiqiang-uestc
force-pushed
the
select_label
branch
from
feed76d
to
f67f5c9
Compare
duanbing
reviewed
Jul 20, 2021
| @@ -357,7 +364,7 @@ def test_one_file(args, bridge, booster, data_file, output_file): | |||
| X, cat_X, X_names, cat_X_names, y, example_ids, raw_ids = \ | |||
| read_data( | |||
| args.file_type, data_file, args.verify_example_ids, | |||
| False, args.ignore_fields, args.cat_fields) | |||
| False, args.ignore_fields, args.cat_fields, args.label_field) | |||
There was a problem hiding this comment.
不是，是想让用户选择哪个列做y
|
LGTM |
chong1144
pushed a commit
that referenced
this pull request
Dec 16, 2021
* feat(tree): select label * feat(tree): fix * feat(tree): add label_feild in script Co-authored-by: 杭卫强 <hangweiqiang@bytedance.com> Co-authored-by: Hang Weiqiang <56426022+hangweiqiang-uestc@users.noreply.github.com> Co-authored-by: 杭卫强 <hangweiqiang@bytedance.com>
chong1144
added a commit
that referenced
this pull request
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.