Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should run functional tests for each pull request and release #29

Closed
luchsh opened this issue May 11, 2021 · 2 comments
Closed

Should run functional tests for each pull request and release #29

luchsh opened this issue May 11, 2021 · 2 comments

Comments

@luchsh
Copy link
Collaborator

luchsh commented May 11, 2021

I do not see that step from directory .github/workflow, please correct me if I'm wrong.

We should run all the functional tests automatically in each sub-repo to ensure no regression, for every pull request.
@SilverRainZ
Copy link
Member

I am not sure what "functional tests" are, every package has its unit test (and as a library package, its function can be tested by unittest). Unittest is runned for every pull request.

@luchsh
Copy link
Collaborator Author

luchsh commented Oct 12, 2021 •
edited
Loading

I am not sure what "functional tests" are, every package has its unit test (and as a library package, its function can be tested by unittest). Unittest is runned for every pull request.

Maybe this one is outdated, let me close this issue.

@luchsh luchsh closed this as completed Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luchsh @SilverRainZ