Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break Change: drop ast.Node API UnsafeArray() and UnsafeMap() #498

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

AsterDY
Copy link
Collaborator

@AsterDY AsterDY commented Aug 10, 2023

Reason: PR #464 changed the underlying storage of ast.Node, thus we can provide directly reference of it like UnsafeArray() and UnsafeMap(). For safety , we dropped these two API

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Merging #498 (e36a683) into main (007f4ff) will decrease coverage by 0.86%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #498      +/-   ##
==========================================
- Coverage   73.70%   72.85%   -0.86%     
==========================================
  Files          58       60       +2     
  Lines        8021     8016       -5     
==========================================
- Hits         5912     5840      -72     
- Misses       1789     1859      +70     
+ Partials      320      317       -3     
Files Changed Coverage Δ
ast/node.go 79.73% <ø> (-0.35%) ⬇️

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AsterDY AsterDY merged commit 81a43a9 into main Aug 10, 2023
29 checks passed
@AsterDY AsterDY deleted the feat/drop_unsafe branch August 10, 2023 09:43
AsterDY added a commit that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants