SVT-AV1 configuration fixes #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradh
commented
Jan 18, 2023
|
So, does this look good to merge now? |
We could, and have flagged this as ready for review. However but there is a potential upstream fix for SVT we could try as a patch instead of the sedinplace option. See https://gitlab.com/AOMediaCodec/SVT-AV1/-/merge_requests/2059#note_1244902169 Do you have a preference? |
|
If you want to bring in the patch instead, that's fine too, yes. |
|
Looks like there is something strange going on with the windows CI (I'm seeing the same problem on my branch) related to the X.509 certs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes missing configuration entry for some build targets, where that resulted in shared libraries.
Breaks on windows-x86. I've left the windows-x86 steps in there and disabled.