Initial commit for JPMS support #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's looking good, thanks! Though, it seems like the formatting fixes I made to the abstract helper classes have been reverted. Could you undo those reverts, that is, not change the formatting? There's also a lot of missing |
Also exclude additional MSVC files from package
|
Now let's give this a try with the 1.5-SNAPSHOT builds! /cc @SamCarlberg |
saudet
pushed a commit
that referenced
this pull request
Feb 17, 2019
saudet
pushed a commit
that referenced
this pull request
Feb 18, 2019
saudet
pushed a commit
that referenced
this pull request
Mar 3, 2019
saudet
pushed a commit
that referenced
this pull request
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains modification to the poms for the new package layout, modularized opencv and ffmpeg.
I didn't include the opencv generated Java, since if I pushed mine, the cuda related classes would be missing.