Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module-info.java #928

Merged
merged 5 commits into from
Aug 18, 2020
Merged

Conversation

MachineIntelligence6
Copy link
Contributor

helper package was missing in the file. Fix Error: module org.bytedeco.opencv does not export org.bytedeco.opencv.helper

helper package was missing in the file. Fix Error Error: module org.bytedeco.opencv does not export org.bytedeco.opencv.helper
@saudet
Copy link
Member

saudet commented Aug 18, 2020

@HGuillemet Let's append to this all other missing helper modules like that.

@saudet saudet requested a review from HGuillemet August 18, 2020 01:39
@HGuillemet
Copy link
Collaborator

I wrote a script to identify source directories without a corresponding export in module-info. It found:

org/bytedeco/cpython/helper
org/bytedeco/opencv/helper
org/bytedeco/qt/helper

and the following directories, which seems to have been introduced after the creation of the module-info:

org/bytedeco/llvm/program
org/bytedeco/tesseract/program

Do you think these 5 directories correspond to packages which must be exported (ie contain Java type that could be accessed by users) ?

@saudet
Copy link
Member

saudet commented Aug 18, 2020 via email

@HGuillemet
Copy link
Collaborator

HGuillemet commented Aug 18, 2020

@AKMANSoft, could you add to your PR these 4 additional exports to their corresponding module-info ?
I don't think I can do it myself without submitting another PR.
Thanks,

@MachineIntelligence6
Copy link
Contributor Author

Yes no problem. I have added the exports.

@saudet saudet merged commit d760b8f into bytedeco:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants