Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignUp/Signin UI modification #191

Merged
merged 3 commits into from
Oct 27, 2022
Merged

Conversation

Rimjhim20
Copy link
Contributor

Describe your changes

I have fixed the overlapping issue for email, password , username at sign-up page(https://noteslify.stonecss.com/Signup)

Screenshots - If Any (Optional)

image

Issue ticket number and link - If Any

#189

Checklist before requesting a review

  • I have performed a self-review of my code.

  • Followed the repository's Contributing Guidelines.

  • I ran the app and tested it locally to verify that it works as expected.

  • I have starred the repository.

Additional Information (Optional)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Rimjhim20, Thanks for contributing and Congrats on opening PR 🎉.

We will try to review as soon as possible and a maintainer will get back to you soon!

Copy link
Member

@MrKrishnaAgarwal MrKrishnaAgarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I have tested it, it works as expected ✔️

Copy link
Member

@devarshishimpi devarshishimpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks For Contributing!!

@devarshishimpi devarshishimpi added enhancement New feature or request v2.0-roadmap Version 2.0 Roadmap hacktoberfest Hacktoberfest hacktoberfest-accepted Hacktoberfest Accepted hacktoberfest2022 Hacktoberfest 2022 labels Oct 27, 2022
@devarshishimpi devarshishimpi added this to the v2.0-roadmap milestone Oct 27, 2022
@devarshishimpi devarshishimpi merged commit 319bcb5 into bytemakers:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest Hacktoberfest hacktoberfest2022 Hacktoberfest 2022 hacktoberfest-accepted Hacktoberfest Accepted v2.0-roadmap Version 2.0 Roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants