Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new URL() instead of regex in isUrl() #36

Merged
merged 1 commit into from
May 10, 2022
Merged

Use new URL() instead of regex in isUrl() #36

merged 1 commit into from
May 10, 2022

Conversation

Drarig29
Copy link
Contributor

Fixes #34

@bytesbay bytesbay merged commit 45b12e2 into bytesbay:main May 10, 2022
bytesbay added a commit that referenced this pull request May 10, 2022
@bytesbay
build of fix #36
0d45e04
@bytesbay
Copy link
Owner

Nice work dude, pushed the build to npm

@bytesbay
Copy link
Owner

With version @0.2.8

@Drarig29
Copy link
Contributor Author

Wait, I'm doing some other things, don't publish yet 😛

@bytesbay bytesbay mentioned this pull request May 10, 2022
Closed
@bytesbay
Copy link
Owner

Getting "Expected signature to be an Uint8Array" in tests, do you also face it ?

@Drarig29
Copy link
Contributor Author

Oh, I do! Let me fix this

@bytesbay
Copy link
Owner

Thanks! Tried to do something with ethereumjs-util version , but didn't help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use new URL() instead of regex in isUrl()
2 participants
@Drarig29 @bytesbay