-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support encrypted wifi password on Appliance.Config.WifiX namespace #60
Support encrypted wifi password on Appliance.Config.WifiX namespace #60
Conversation
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
- | Generic Password | 0cc2300 | lib/api.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
a31fbd5
to
3e38712
Compare
The detected secret is the AES256 initialization vector (iv), which is hardcoded to a fixed value by meross. |
@DominikGebhart Thank you for pointing me at this PR. |
SUCCESS - THANK YOU :-) MSS310 Hardware v6 Firmware 6.3.6 WORKED MSS310 Hardware v6 Firmware 6.3.6 MSS310 Hardware v6 Firmware 6.1.12 However, for the Firmware 6.1.12 device I am seeing these "SIGN ERROR" messages in MQTT at every update interval: Examples: {"header":{"messageId":"15419275f57bebee8720af506f2b5438","namespace":"Appliance.Control.Bind","method":"ERROR","payloadVersion":1,"from":"/appliance/OBFUSCATED/publish","uuid":"OBFUSCATED","timestamp":1676972478,"timestampMs":366,"sign":"efa361abcOBFUSCATED2b0e0cf"},"payload":{"error":{"code":5001,"detail":"sign error"}}} {"header":{"messageId":"4eb42fb6c584409aa9c6eaf78af9d334","namespace":"Appliance.Control.Electricity","method":"ERROR","payloadVersion":1,"from":"/appliance/OBFUSCATED/publish","uuid":"OBFUSCATED","timestamp":1676972663,"timestampMs":888,"sign":"ebbOBFUSCATEDcdbf605f"},"payload":{"error":{"code":5001,"detail":"sign error"}}} {"header":{"messageId":"2d088ea94d7b4ce89cd33a3f000721d8","namespace":"Appliance.Control.ConsumptionX","method":"ERROR","payloadVersion":1,"from":"/appliance/OBFUSCATED/publish","uuid":"OBFUSCATED","timestamp":1676972635,"timestampMs":434,"sign":"4ca46OBFUSCATEDfb66d"},"payload":{"error":{"code":5001,"detail":"sign error"}}} |
@bytespider would you mind considering merging the pull? It works great and is (at least for me) the solution for @DominikGebhart thank you very much for this addition! |
@wsw70 thanks for reminding me about this. I'm unable to test this as all my devices are FW v2 and v4. @DominikGebhart do we know which versions work with the new command? It might be worth documenting it somewhere like the command help. |
No, i don't have a list. I assume it's all newish firmware versions. |
I have a device with 3.1.5 that I paired with a previous version. This did not work for another device I upgraded to 3.2.2, but worked with @DominikGebhart PR. This is one data point and it was about 2 years that I did not pair anything so I may be wrong. One thing is for sure: using |
Support for Wifi configuration on the Appliance.Config.WifiX namespace which needs an encrypted password.
Adds
--use-wifi-x
commandline argument.Once more thoroughly testet, we might think about using the Appliance.Config.WifiX way per default to make it harder to snoop the actual wifi password by someone listening in on that unsecured access point dataframes.
Successfully tested on a mss310eu plug version 6, firmware version 6.1.12
Feedback or pull appreciated