Stop adding statusCode #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a result of L141 and L152 in ec73fd4, I now get bodies that have a statusCode property that I wasn't expecting, like: ``` { "metadata": { "validation_response": { "code": 404, "message": "Not Found" } }, "statusCode": 500 } ``` The preferred way to get the statusCode is to use the [`resolveWithFullResponse` option](https://www.npmjs.com/package/request-promise#get-the-full-response-instead-of-just-the-body).
|
Also, see the 4th example of a request in this package's README. |
|
Also getting these errors now: |
|
This is causing INC0456212. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of L141 and L152 in ec73fd4,
I now get bodies that have a statusCode property that I wasn't expecting, like:
The preferred way to get the statusCode is to use the
resolveWithFullResponseoption.