Update to Terraform v1.0.0, use Dependabot #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Plan:will create 1 resource:
will update 7 resources:
will replace (delete then create) 1 resource:
|
GaryGSC
commented
Jun 15, 2021
Comment on lines
+25
to
+35
| # - package-ecosystem: terraform | ||
| # directory: '/terraform-iac/dev/app' | ||
| # schedule: | ||
| # interval: daily | ||
| # target-branch: dev | ||
|
|
||
| # - package-ecosystem: terraform | ||
| # directory: '/terraform-iac/dev/setup' | ||
| # schedule: | ||
| # interval: daily | ||
| # target-branch: dev |
There was a problem hiding this comment.
I don't love the idea of getting 8 PRs whenever we need to update the AWS provider, but I can't think of a way around that until dependabot/dependabot-core#2178 is added.
|
Are we thinking that the Dependabot stuff is blocked on #212? |
|
It looks like the main difference to the TF plan is the way we now mark more things as sensitive. |
yoshutch
reviewed
Jun 16, 2021
yoshutch
approved these changes
Jun 16, 2021
stuft2
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #226
Refs: #228