Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pins and wires during port and cable addition in definition #159

Merged

Conversation

ganeshgore
Copy link
Contributor

Added optional pins and wires parameters in create_port and create_cable methods of definition.
It will create a defined number of pins or wires while creating a Port or cable.

  • Do not break existing functionality
  • Unit tests are updated

@ganeshgore
Copy link
Contributor Author

Parameter sequence keeps changing arbitrary during comparison in the following test

assert composer.file.compare(expected)

Possibly VERILOG.Parameters should be defined as an OrderedDictionaty or sort parameters during writing.

Travis output

The composer wrote:
"module test_definition
#(
    parameter no_default,
    parameter key = value
)(
    my_port,
    my_port2
);
"
This was compared to:
"module test_definition
#(
    parameter key = value,
    parameter no_default
)(
    my_port,
    my_port2
);
"

@jacobdbrown4
Copy link
Collaborator

These additions seem good!

@ganeshgore ganeshgore changed the base branch from master to ganesh_contributions October 27, 2021 00:59
@jacobdbrown4 jacobdbrown4 self-assigned this Oct 27, 2021
@jacobdbrown4
Copy link
Collaborator

Those optional parameter additions look good to me.

Yes I think the OrderedDict() will help that. If you are able to change that and then commit it, I'll merge this PR.

@jacobdbrown4 jacobdbrown4 merged commit 793df82 into byuccl:ganesh_contributions Nov 2, 2021
@ganeshgore ganeshgore deleted the functional_addition branch December 8, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants