try to fix compat with googletest 1.15#874
Merged
bradh352 merged 1 commit intoc-ares:mainfrom Sep 4, 2024
Merged
Conversation
bradh352
added a commit
that referenced
this pull request
Sep 4, 2024
Due to running containerized tests we had to cut and paste the `TEST_P` macro definition in `googletest/include/gtest/gtest-param-test.h`, and modify it as it isn't designed to be wrapped in any way. Unfortunately this tends to change from release to release, usually in minor ways ... but also google test specifically doesn't advertise its own version so it can be hard to work around. Lets try to fix compatibility with google test 1.15 Fixes #873 Authored-By: Brad House (@bradh352)
bradh352
added a commit
that referenced
this pull request
Sep 4, 2024
Due to running containerized tests we had to cut and paste the `TEST_P` macro definition in `googletest/include/gtest/gtest-param-test.h`, and modify it as it isn't designed to be wrapped in any way. Unfortunately this tends to change from release to release, usually in minor ways ... but also google test specifically doesn't advertise its own version so it can be hard to work around. Lets try to fix compatibility with google test 1.15 Fixes #873 Authored-By: Brad House (@bradh352)
bradh352
added a commit
that referenced
this pull request
Sep 4, 2024
Due to running containerized tests we had to cut and paste the `TEST_P` macro definition in `googletest/include/gtest/gtest-param-test.h`, and modify it as it isn't designed to be wrapped in any way. Unfortunately this tends to change from release to release, usually in minor ways ... but also google test specifically doesn't advertise its own version so it can be hard to work around. Lets try to fix compatibility with google test 1.15 Fixes #873 Authored-By: Brad House (@bradh352)
bradh352
added a commit
that referenced
this pull request
Sep 4, 2024
Due to running containerized tests we had to cut and paste the `TEST_P` macro definition in `googletest/include/gtest/gtest-param-test.h`, and modify it as it isn't designed to be wrapped in any way. Unfortunately this tends to change from release to release, usually in minor ways ... but also google test specifically doesn't advertise its own version so it can be hard to work around. Lets try to fix compatibility with google test 1.15 Fixes #873 Authored-By: Brad House (@bradh352)
bradh352
added a commit
that referenced
this pull request
Sep 4, 2024
Due to running containerized tests we had to cut and paste the `TEST_P` macro definition in `googletest/include/gtest/gtest-param-test.h`, and modify it as it isn't designed to be wrapped in any way. Unfortunately this tends to change from release to release, usually in minor ways ... but also google test specifically doesn't advertise its own version so it can be hard to work around. Lets try to fix compatibility with google test 1.15 Fixes #873 Authored-By: Brad House (@bradh352)
bradh352
added a commit
that referenced
this pull request
Sep 4, 2024
Due to running containerized tests we had to cut and paste the `TEST_P` macro definition in `googletest/include/gtest/gtest-param-test.h`, and modify it as it isn't designed to be wrapped in any way. Unfortunately this tends to change from release to release, usually in minor ways ... but also google test specifically doesn't advertise its own version so it can be hard to work around. Lets try to fix compatibility with google test 1.15 Fixes #873 Authored-By: Brad House (@bradh352)
michael-dev
pushed a commit
to HamelinPorts/android_external_c-ares
that referenced
this pull request
Apr 25, 2026
Due to running containerized tests we had to cut and paste the `TEST_P` macro definition in `googletest/include/gtest/gtest-param-test.h`, and modify it as it isn't designed to be wrapped in any way. Unfortunately this tends to change from release to release, usually in minor ways ... but also google test specifically doesn't advertise its own version so it can be hard to work around. Lets try to fix compatibility with google test 1.15 Fixes c-ares#873 Authored-By: Brad House (@bradh352)
michael-dev
pushed a commit
to HamelinPorts/android_external_c-ares
that referenced
this pull request
Apr 25, 2026
Due to running containerized tests we had to cut and paste the `TEST_P` macro definition in `googletest/include/gtest/gtest-param-test.h`, and modify it as it isn't designed to be wrapped in any way. Unfortunately this tends to change from release to release, usually in minor ways ... but also google test specifically doesn't advertise its own version so it can be hard to work around. Lets try to fix compatibility with google test 1.15 Fixes c-ares#873 Authored-By: Brad House (@bradh352)
michael-dev
pushed a commit
to HamelinPorts/android_external_c-ares
that referenced
this pull request
Apr 25, 2026
Due to running containerized tests we had to cut and paste the `TEST_P` macro definition in `googletest/include/gtest/gtest-param-test.h`, and modify it as it isn't designed to be wrapped in any way. Unfortunately this tends to change from release to release, usually in minor ways ... but also google test specifically doesn't advertise its own version so it can be hard to work around. Lets try to fix compatibility with google test 1.15 Fixes c-ares#873 Authored-By: Brad House (@bradh352)
michael-dev
pushed a commit
to HamelinPorts/android_external_c-ares
that referenced
this pull request
Apr 25, 2026
Due to running containerized tests we had to cut and paste the `TEST_P` macro definition in `googletest/include/gtest/gtest-param-test.h`, and modify it as it isn't designed to be wrapped in any way. Unfortunately this tends to change from release to release, usually in minor ways ... but also google test specifically doesn't advertise its own version so it can be hard to work around. Lets try to fix compatibility with google test 1.15 Fixes c-ares#873 Authored-By: Brad House (@bradh352)
michael-dev
pushed a commit
to HamelinPorts/android_external_c-ares
that referenced
this pull request
Apr 25, 2026
Due to running containerized tests we had to cut and paste the `TEST_P` macro definition in `googletest/include/gtest/gtest-param-test.h`, and modify it as it isn't designed to be wrapped in any way. Unfortunately this tends to change from release to release, usually in minor ways ... but also google test specifically doesn't advertise its own version so it can be hard to work around. Lets try to fix compatibility with google test 1.15 Fixes c-ares#873 Authored-By: Brad House (@bradh352)
michael-dev
pushed a commit
to HamelinPorts/android_external_c-ares
that referenced
this pull request
Apr 25, 2026
Due to running containerized tests we had to cut and paste the `TEST_P` macro definition in `googletest/include/gtest/gtest-param-test.h`, and modify it as it isn't designed to be wrapped in any way. Unfortunately this tends to change from release to release, usually in minor ways ... but also google test specifically doesn't advertise its own version so it can be hard to work around. Lets try to fix compatibility with google test 1.15 Fixes c-ares#873 Authored-By: Brad House (@bradh352)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to running containerized tests we had to cut and paste the
TEST_Pmacro definition ingoogletest/include/gtest/gtest-param-test.h, and modify it as it isn't designed to be wrapped in any way. Unfortunately this tends to change from release to release, usually in minor ways ... but also google test specifically doesn't advertise its own version so it can be hard to work around.Lets try to fix compatibility with google test 1.15
Fixes #873
Authored-By: Brad House (@bradh352)