Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't install anything past 0.5.5 #9

Closed
PMunch opened this issue Oct 5, 2023 · 5 comments
Closed

Can't install anything past 0.5.5 #9

PMunch opened this issue Oct 5, 2023 · 5 comments

Comments

@PMunch
Copy link

PMunch commented Oct 5, 2023

Trying to install a newer version of this package via Nimble just yields this error message:

$ nimble install adix@0.5.7
Downloading https://github.com/c-blake/adix using git
  Verifying dependencies for adix@0.5.7
   Warning: No nimblemeta.json file found in /home/peter/.nimble/pkgs/rod-0.1.0
      Info: Dependency on cligen@>= 1.6.7 already satisfied
  Verifying dependencies for cligen@1.6.15
 Installing adix@0.5.7
   Building adix/util/lfreq using c backend
/tmp/nimble_12540/githubcom_cblakeadix_0.5.7/util/lfreq.nim(33, 12) Error: undeclared identifier: 'i'
candidates (edit distance, scope distance); see '--spellSuggest': 
 (1, 1): 'h' [param declared in /tmp/nimble_12540/githubcom_cblakeadix_0.5.7/util/lfreq.nim(29, 16)]
 (1, 2): 's' [var declared in /tmp/nimble_12540/githubcom_cblakeadix_0.5.7/util/lfreq.nim(17, 5)]
 (1, 4): '$' [func declared in /home/peter/.choosenim/toolchains/nim-1.6.14/lib/system/dollars.nim(25, 8)]
 (1, 4): '$' [func declared in /home/peter/.choosenim/toolchains/nim-1.6.14/lib/system/dollars.nim(25, 8)]

Version 0.5.5 works

@Vindaar
Copy link
Collaborator

Vindaar commented Oct 5, 2023

I cannot reproduce that locally (also 0.5.8 is the latest tag). But I'm running Nim devel. Can you check if it works on 2.0 or devel for you and/or if 0.5.8 works?

@PMunch
Copy link
Author

PMunch commented Oct 5, 2023

Ah, turns out I had 1.6.14 checked out. With 2.0.0 I was able to install 0.5.8 (I tried 0.5.8 earlier as well, I just happened to copy the output for when I tried to install 0.5.7). The required Nim version in the nimble file should probably be bumped up to 2.0.0.

@Vindaar
Copy link
Collaborator

Vindaar commented Oct 5, 2023

The required Nim version in the nimble file should probably be bumped up to 2.0.0.

I guess it's something that can be fixed. @c-blake is on vacation this week. I'm sure he'll have a look once he's back.

@c-blake
Copy link
Owner

c-blake commented Oct 10, 2023

Sorry for the delay. As @Vindaar mentioned, I was out of town with only smart phone access where I find it almost impossible to do fast & furious source code edits.

Unfortunately, I could not get the New style concept matching (or {.explain.} to show why matching failed) working on older Nim's. So, I just forced an upgrade of the version.

This may sadly lock out people on older, frozen versions of Nim. On the plus side of the trade-off ledger, the core abstraction of an open-addressed hash table as just a specialized array with a few capabilities on array elements is more manifest with the adix/oats approach.

@PMunch - please let me know if this does not solve your problems.

@PMunch
Copy link
Author

PMunch commented Oct 10, 2023

Should work fine. Maybe drop a note somewhere that older versions of Nim must use 0.5.5 so people dont have to try every version. Other than that it should be fine.

c-blake added a commit that referenced this issue Oct 10, 2023
about how to use older nim, if one must (although you probably need
a much smarter package management strategy than nimble to do so) as
per #9 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants