Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken with devel #84

Closed
genotrance opened this issue Dec 30, 2018 · 4 comments · Fixed by nim-lang/Nim#10131
Closed

Broken with devel #84

genotrance opened this issue Dec 30, 2018 · 4 comments · Fixed by nim-lang/Nim#10131

Comments

@genotrance
Copy link
Contributor

cligen is breaking with devel today.

https://travis-ci.org/genotrance/nimterop/jobs/473465269#L395
@genotrance
Copy link
Contributor Author

Looks like this broke your code:

nim-lang/Nim@0831292

timotheecour added a commit to timotheecour/Nim that referenced this issue Dec 30, 2018
@timotheecour
fix typetraits.$ regression c-blake/cligen#84
59b09c1
@timotheecour timotheecour mentioned this issue Dec 30, 2018
Merged
@timotheecour
Copy link
Contributor

timotheecour commented Dec 30, 2018 •
edited
Loading

seems to work after this PR:
nim-lang/Nim#10131

(please let me know if it doesn't work for you, but it does for me:
nimble build works inside nimterop after this PR)

Araq pushed a commit to nim-lang/Nim that referenced this issue Dec 30, 2018
@timotheecour @Araq
fix typetraits.$ regression c-blake/cligen#84 (#10131)
a6633b9 
* fix typetraits.`$` regression c-blake/cligen#84
* add test
@timotheecour
Copy link
Contributor

@genotrance PR was merged, can you close if it works for you now?

@c-blake
Copy link
Owner

c-blake commented Jan 3, 2019

This works for me. @timotheecour - thanks for the quick fix-up. Closing.

@c-blake c-blake closed this as completed Jan 3, 2019
@c-blake c-blake mentioned this issue Mar 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix typetraits.$ regression https://github.com/c-blake/cligen/issues/84 timotheecour/Nim
3 participants
@genotrance @timotheecour @c-blake