update makefile for build/get #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disk: writeblock
disk: readblock
ReadBlock: return EOF correctly
- add a FIXME in TestPartlyReadBlock
add block tests and fix minor bugs
Use basic slice instead of buffer struct. This makes code simpler and avoids pre-optimization.
disk: add WriteAt
some bugs fixes for WriteAt
fix erasure.go cgo import
If there is a full block and the client is reading half of them, we should first read the full block out, compare the crc, then copy data into client buffer.
readBlock: don't return error if input buffer is smaller than a block
The server side will print out error like this: ``` 2015/06/03 05:57:52 [INFO][github.com/c-fs/cfs/server] server.go:36: server: write error (open cfs0000/foodir/foo: no such file or directory) ```
More error checking and return correct bytes copied
server: print disk.writeAt error when calling write func
run `./scripts/genproto.sh` will generate proto.
scripts: add genproto.sh
Update README.md
move a testcase to read crc error test
add Makefile for `go test` and `go vet`
| go-vet: | ||
| @find . -name '*.go' | xargs -L 1 go tool vet | ||
| test: vet build | ||
| go test -p 8 -race -d ./... |
There was a problem hiding this comment.
go test -p 8 -race -d ./... doesn't work for me for some reasons.
And I believe ? github.com/c-fs/cfs/stats [no test files] will show up. I don't want these show up, so I tried to grep all test file
yutongp
force-pushed
the
master
branch
4 times, most recently
from
6f72d86
to
6d09895
Compare
|
Shall we rebase or simply close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go build builds everything now.
for #18