-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Drill Features #2
base: main
Are you sure you want to change the base?
Conversation
It looks like the code formatter you used changed the style of all the HTML and JS, so the entirety of both files is being completely replaced. Can you use Prettier (VS Code extension -- or some similar tool) to reformat the code how it was before?
Once the formatting is fixed, I can take a closer look at the changes. |
Hmm, I did use Prettier to format the document, is there a settings file I can find to enter the options you have? |
In your VS Code settings.json (after going into Settings, click the button in the top right corner that says "Open Settings (JSON)"), paste these settings:
Or set them manually within the settings GUI. |
Alright, I fixed the formatting. Now the only revisions are the actual changes I made. |
I have added to the web app some additional drill features that are commonly seen throughout Summer Sessions and Tryouts. Here are the features I have added:
Randomized Slow Turn and Adjusted-Step Counts
While most slow turns are 8 counts, sometimes we can encounter a slow turn of any number of counts. When a slow turn is about to be added to the drill, the number of counts in the turn's name are replaced with a random element in the
slowTurn90CountsWeighted
andslowTurn180CountsWeighted
arrays, for slow turns of 90° and 180°, respectively.Examples:
I have also done the same thing with adjusted-step moves, using the
adjustedStepCountsWeighted
array.Examples:
x-Countdowns
One drill element that wasn't present in the app was x-Countdowns (e.g. 3-Countdown). I used a similar technique for the randomized slow turn and adjusted-step counts to randomly generate the length of the countdown, and the different TTRs present (with the help of
turnsTurnedOn
to only select TTRs that were selected by the user, and thecountdownLengthsWeighted
andcountdownTTRsWeighted
arrays to generate the countdown's length and TTRs)Examples:
Box of Lefts/Rights
This was the simplest of the features to implement, as they were simply hard coded into the array of moves: