This repository has been archived by the owner on Jan 12, 2023. It is now read-only.
Add upper version limit for rdflib #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdflib 5.0.0 reworked some amount of their interface, which breaks things here. Minimally, SPARQLWrapper is no longer used, and a requests based wrapper internal to rdflib is now used, which breaks compatibility with older RDF stores that do not follow the SPARQL Protocol 1.1 spec. Setting this to minimize the break here, with a look to move to rdflib 5 in the next major version bump of gutenberg itself. Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
=======================================
Coverage 95.74% 95.74%
=======================================
Files 29 29
Lines 1033 1033
=======================================
Hits 989 989
Misses 44 44
Continue to review full report at Codecov.
|
c-w
approved these changes
Apr 19, 2020
|
Will fix the azure pipelines and then merge. |
MasterOdin
force-pushed
the
MasterOdin-patch-2
branch
2 times, most recently
from
f82a45e
to
7c02389
Compare
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
MasterOdin
force-pushed
the
MasterOdin-patch-2
branch
from
7c02389
to
3a7fca9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdflib 5.0.0 reworked some amount of their interface, which breaks things here. Minimally, SPARQLWrapper is no longer used, and a requests based wrapper internal to rdflib is now used, which breaks compatibility with older RDF stores that do not follow the SPARQL Protocol 1.1 spec. Setting this to minimize the break here, with a look to move to rdflib 5 in the next major version bump of gutenberg itself.