Buffer has limitation. Used string instead of Buffer. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@isabek thanks for this ;) |
|
@ayhankuru thanks for your module. Will you merge my pull-request with master? |
|
@isabek test and merge request :) |
|
@ayhankuru I have added test for my pull-request. I have merged master with my pull-request and used locally. It would be cool, if you coluld add :) |
c0b41
added a commit
that referenced
this pull request
Apr 11, 2015
Buffer has limitation. Used string instead of Buffer.
|
@ayhankuru thanks. Could you add version to this module? |
|
@isabek tidy5 version? |
|
@ayhankuru yeah. |
|
@isabek sure :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tidy's first argument is large, I get error
buffer.js:496 buf.copy(buffer, pos);. I have used string instead of Buffer.