Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditWebhooks improvements #3

Open
2 of 3 tasks
ArjixWasTaken opened this issue Oct 7, 2021 · 2 comments
Open
2 of 3 tasks

EditWebhooks improvements #3

ArjixWasTaken opened this issue Oct 7, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@ArjixWasTaken
Copy link

ArjixWasTaken commented Oct 7, 2021

  • First of all, change the icon, the QR code icon makes no sense.
  • Second of all, you should save the webhooks config locally and immediately use the saved data when opening the menu (so it's faster) and just update that data.
  • Also when creating/deleting a webhook it does not reflect in the UI until you go back and open the menu again.
C10udburst added a commit that referenced this issue Oct 8, 2021
@C10udburst
Copy link
Member

Second of all, you should save the webhooks config locally and immediately use the saved data when opening the menu (so it's faster) and just update that data.

could you elaborate?

@ArjixWasTaken
Copy link
Author

ArjixWasTaken commented Oct 9, 2021

Second of all, you should save the webhooks config locally and immediately use the saved data when opening the menu (so it's faster) and just update that data.

could you elaborate?

It takes about 2 or 3 seconds for the menu to load whenever you open it.
I bet its because you make api requests to get the data you want.
You could save the api responses to reuse them so that you can immediately show the menu and after that make a fresh request to fetch the new data.

@C10udburst C10udburst added the enhancement New feature or request label Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants