Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opt in Android permissions #44

Merged
merged 3 commits into from
Jul 10, 2018
Merged

Opt in Android permissions #44

merged 3 commits into from
Jul 10, 2018

Conversation

Gregoirevda
Copy link
Contributor

@Gregoirevda Gregoirevda commented Jul 5, 2018 •
edited
Loading

Current:

  • delete the permission in the AndroidManifest in the node_modules

If you clone the repo again and yarn permissions will be reset.

PR
No default permissions, add in README to add permissions in app AndroidManifest.xml

@c19354837
Copy link
Owner

Thanks for your PR.

This would cause a breaking change.

I consider to merge it in V 1.5.0.

@Gregoirevda
Copy link
Contributor Author

Thanks, would be great for us!

@c19354837 c19354837 merged commit caaf7ab into c19354837:master Jul 10, 2018
@c19354837
Copy link
Owner

V1.5.0 is available!

I've updated the README on your basis.

@Gregoirevda
Copy link
Contributor Author

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gregoirevda @c19354837