This repository has been archived by the owner on Aug 1, 2019. It is now read-only.
Use fragment params for /auth page #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To improve its cachability.
|
Must the SSO URL in Discourse also be updated? @gberaudo? |
|
No idea about the Discourse SSO URL but else LGTM. |
|
@tsauerwein, yes I guess. But I don't know if Discourse supports this. |
I am afraid it does not. I will rework this. |
tsauerwein
changed the title
Discourse does not support URLs with fragment params. That's why a separate view (without ETag) is used for Discourse.
tsauerwein
changed the title
|
The URL will have to be updated in Discourse the next time the demo is updated: |
|
Are there still things to do with this PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve its cachability.
Closes #585