Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home Page Tutorial Card Buttons Not Working. #109 Fixed #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Hemu21
Copy link

@Hemu21 Hemu21 commented Feb 26, 2024

When you click on buttons present in home page tutorial. only upvoting and downvoting are working remaining are not working. This issue is Fixed with this PR.

Description

I added changes to the buttons and added functionality to all buttons. I added the saved bookmarks to firestore database. To show that user is bookmarked it or not.

Related Issue

Home Page Tutorial Card Buttons Not Working resolve #109

steps to reproduce

Set-up the localhost and run it.
Now go to home page after login.
If tutorial card present if not create a tutorial
Now click on the buttons on the tutorial
You will it as below.

homepage_tutorial_buttons_issue.mp4

Link of the Issue

https://github.com/c2siorg/Codelabz/issues/109

Motivation and Context

In the design you see the buttons but the working functionality to that buttons are not given. This issue leads to loss of working of website. This effects on user experience. Fixing This issue Increases User Experience. I fixed this issue.

How Has This Been Tested?

  • Set-up the localhost and run it.
  • Now go to home page after login.
  • If tutorial card present if not create a tutorial
  • Now click on the buttons on the tutorial
  • check they are working or not.

Screenshots or GIF (In case of UI changes):

homepage_tutorial_buttons_issue_fix.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Review Request

@ABHISHEK-PANDEY2 @Maahi10001 @Shiva-Nanda @c2sibot Please Review My PR. Approve My PR

@rohitPandey469
Copy link

Good job doing it but kindly refer to Scorelab's Codelabz and do not create repetitive PR,
And here if you create separate tickets for each buttons then it would be easy for maintainers to pick out the best code out of multiple PRs for one single functionality. Although @ABHISHEK-PANDEY2 has told not to repeat the PR. And else it's your choice brother.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home Page Tutorial Card Buttons Not Working.
2 participants