Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor mermaid issues #39

Closed
xCaradhras opened this issue Jul 25, 2023 · 4 comments
Closed

Some minor mermaid issues #39

xCaradhras opened this issue Jul 25, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@xCaradhras
Copy link

Hello,

I just tested the new mermaid extension. Really nice extension that makes generation of graphics a lot easier!

The readibility of some of the supported diagrams in dark mode could be improved. Here you have a sample:
test.md with an example:
grafik

(All sample code taken from here: https://mermaid.live) Also maybe include more demo code into your readme to show the capabilities of mermaid.

Two small requests/ideas not related to graph generation (but too small for separate issues): I would welcome drag & drop support for mdview :) and a menu for reciently opened files. For the drag & drop support, maybe a preference for "open in new instance" vs "reuse instance" vs "ask what to do" would be nice.

Thx & Best regards

@github-actions github-actions bot added the needs reaction Owner didn't react to this issue yet label Jul 25, 2023
@c3er
Copy link
Owner

c3er commented Jul 25, 2023

Hi, thanks again for filing this issue!

I'll see, what I can do to improve Mermaid readability.

Two small requests/ideas not related to graph generation (but too small for separate issues): I would welcome drag & drop support for mdview :) and a menu for reciently opened files. For the drag & drop support, maybe a preference for "open in new instance" vs "reuse instance" vs "ask what to do" would be nice.

Could you be so nice and make an issue for each feature request? This would be easier for me to keep track of what has to be done. Also, if I have a question regarding a feature, it would be easier to follow each discussion.

@c3er c3er removed the needs reaction Owner didn't react to this issue yet label Jul 25, 2023
@xCaradhras
Copy link
Author

Done :)

@c3er c3er added the bug Something isn't working label Jul 27, 2023
@c3er
Copy link
Owner

c3er commented Jul 30, 2023

(All sample code taken from here: https://mermaid.live/) Also maybe include more demo code into your readme to show the capabilities of mermaid.

Kudos to your test document! I see, that their are multiple examples with heavy readability problems in dark mode.

I think, I will create an "examples document" from your test file and link it in the "flavor.md" file.

c3er added a commit that referenced this issue Jul 31, 2023
Based on the file provided in issue #39 by @xCaradhras.
#39
c3er added a commit that referenced this issue Jul 31, 2023
@c3er
Copy link
Owner

c3er commented Sep 19, 2023

Version 3.0.0 does now regard the dark mode for Mermaid diagrams.

Screenshot of a Mermaid sequence diagram as rendered in Markdown Viewer in dark mode

As mentioned, I created an examples document from your test file.

Feel free to open another issue!

@c3er c3er closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants