Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional, usual ways to zoom the content #50

Closed
ElektroStudios opened this issue Feb 9, 2024 · 2 comments
Closed

Support additional, usual ways to zoom the content #50

ElektroStudios opened this issue Feb 9, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@ElektroStudios
Copy link

ElektroStudios commented Feb 9, 2024

I just noticed that the hotkey to zoom out it does not recognize the minus key from the numeric pad. Although it works fine for the other minus key.

I'm referring to this code:

Note: the hot key to zoom in, it properly recognizes both "+" keys in the keyboard.

I don't have enough experience with javascript, but I've tried to research a little bit and I think the solution could be to handle the key with id. NumpadSubtract (among with - and Minus to catch also the other minus key) as mentioned here:

Also, to avoid opening a new issue and being annoying, I take the opportunity to suggest to add CONTROL+MOUSE SCROLL BUTTON too. This key combination is available in almost all file viewers and editors, including web-browsers. It would be a tiny Quality of Life improvement.

Thanks for your attention.

@github-actions github-actions bot added the needs reaction Owner didn't react to this issue yet label Feb 9, 2024
@c3er
Copy link
Owner

c3er commented Feb 10, 2024

Thanks again🙂

I think, this could be implemented by just extending one if:

if (input.control && input.key === "+") {

Though, I'm not sure about the mouse wheel but this shouldn't be too difficult either.

I'll see that I implement this to the next release together with #48. Pull requests are welcome!

@c3er c3er changed the title Hotkey to Zoom Out does not work as expected. Support additional, usual ways to zoom the content Feb 10, 2024
@c3er c3er added enhancement New feature or request and removed needs reaction Owner didn't react to this issue yet labels Feb 10, 2024
c3er added a commit that referenced this issue Apr 21, 2024
Now supported:
- Minus key "-" on numpad
- Control + mouse wheel

This fixes issue #50
@c3er
Copy link
Owner

c3er commented May 5, 2024

I just released version 3.1.0, containing this feature. Enjoy!

I'm sorry, to not have fixed the table rendering issue yet but you may see that this is not trivially to fix.

@c3er c3er closed this as completed May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants