Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add axis.x.inner #2299

Merged
merged 2 commits into from
Mar 21, 2018
Merged

Add axis.x.inner #2299

merged 2 commits into from
Mar 21, 2018

Conversation

masayuki0812
Copy link
Member

@masayuki0812 masayuki0812 commented Feb 21, 2018

Fix #794.

@codecov-io
Copy link

codecov-io commented Feb 21, 2018

Codecov Report

Merging #2299 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2299      +/-   ##
==========================================
+ Coverage   74.92%   74.95%   +0.03%     
==========================================
  Files          51       51              
  Lines        4227     4233       +6     
==========================================
+ Hits         3167     3173       +6     
  Misses       1060     1060
Impacted Files Coverage Δ
src/config.js 95.83% <ø> (ø) ⬆️
src/axis.js 95.8% <100%> (+0.05%) ⬆️
src/size.js 93.67% <100%> (ø) ⬆️
src/core.js 89.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eb2df7...bf7cd6b. Read the comment docs.

@franciscbalint
Copy link

Thank you!

@Mobiletainment
Copy link

Looking forward to having this released.
Thank you!

@kt3k
Copy link
Member

kt3k commented Mar 1, 2018

Looks good to me.

@masayuki0812
Do you think it's ready to release? If you think so, I'll ship it soon.

@masayuki0812
Copy link
Member Author

@kt3k
Thanks for your review. I think this can be released.

@kt3k kt3k merged commit 8ed8560 into master Mar 21, 2018
@kt3k kt3k deleted the feature/axis_x_inner branch March 21, 2018 14:18
@kt3k
Copy link
Member

kt3k commented Mar 21, 2018

@masayuki0812
Thanks for the confirmation. Released this as v0.4.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants