Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the graph to follow the container vertical resize #2376

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow the graph to follow the container vertical resize #2376

wants to merge 1 commit into from

Conversation

jsiembida
Copy link

Hello,

  • C3 efab2ea (latest master)
  • D3 v5 (5.4.0)
  • Tested browsers: latest chrome, latest safari, latest FF and IE11

Observed behavior:
When changing the vertical window size the chart only updates towards
smaller height (can only shrink). When the window is getting higher, the chart
stays at the last height. The horizontal resizing works as expected.

This is CodePen (couldn't reproduce it using jsFiddle) of the original C3:

https://codepen.io/anon/pen/aGewNy

This is CodePen with the fix applied:

https://codepen.io/anon/pen/qYejZp

Please drag the horizontal bar up and down and observe how chart follows the resizing.

regards,

jarek

@codecov-io
Copy link

Codecov Report

Merging #2376 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2376      +/-   ##
==========================================
- Coverage   77.23%   77.22%   -0.01%     
==========================================
  Files          51       51              
  Lines        4138     4137       -1     
==========================================
- Hits         3196     3195       -1     
  Misses        942      942
Impacted Files Coverage Δ
src/core.js 89.22% <ø> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efab2ea...1301136. Read the comment docs.

@panthony
Copy link
Contributor

Hi @jsiembida, thanks for the contribution.

Tests are required for pull requests, it ensures the changes are working as expected and serve as documentation on how the library is supposed to behave for future contributors.

Did you find out why max-height was added to begin with? Was it trying to fix a specific issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants