Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write the correct field type to ply #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JoshChristie
Copy link
Contributor

Write the given type to a ply field, instead of always writing Float32.

@JoshChristie
Copy link
Contributor Author

Ping.

The main difference is that instead of always writing Float32 it will write the type stored in the array.

E.g. The types that I've tested this with are:

Array{N0f8, 1}
Array{UInt16, 1}
Array{UInt8, 1}
Array{UInt32, 1}
Array{Float32, 1}
Array{Float64, 1}

@c42f
Copy link
Owner

c42f commented Oct 3, 2017

As we discussed a few weeks ago, displaz needs some changes upstream to make this a coherent change. The core problem is that ply doesn't have a way to communicate whether a given field contains fixed point numbers (eg, colors should generally be scaled to be between 0 and 1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants