Automated form list tests #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineiti
requested changes
Jan 16, 2024
web/frontend/tests/formIndex.spec.ts
Outdated
| const user = sciper === SCIPER_USER ? User | ||
| : sciper === SCIPER_ADMIN ? Admin | ||
| : undefined; | ||
| const user = sciper === SCIPER_USER ? User : sciper === SCIPER_ADMIN ? Admin : undefined; |
There was a problem hiding this comment.
can you read and understand this in one breath?
I think superfluous parentheses would help me:
Suggested change
| const user = sciper === SCIPER_USER ? User : sciper === SCIPER_ADMIN ? Admin : undefined; | |
| const user = sciper === SCIPER_USER ? User : ( sciper === SCIPER_ADMIN ? Admin : undefined ); |
There was a problem hiding this comment.
I agree on the readability, but sadly this breaks the linting
There was a problem hiding this comment.
added a commit w/ linting on that line disabled, so we can either use that or leave it like before
ineiti
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the form list, including:
it does not for the moment contain internalization tests, which will be added later
closes #70