Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

github/lint-build-test: patch cargo-ndk #104

Merged
merged 1 commit into from
Aug 2, 2022
Merged

github/lint-build-test: patch cargo-ndk #104

merged 1 commit into from
Aug 2, 2022

Conversation

tharvik
Copy link
Collaborator

@tharvik tharvik commented Jul 20, 2022

Rust is moving away from gcc in favor of libunwind, but prebuild std for some platform (such as Android) are still using it. This patch creates the needed indirection gcc -> unwind.

See bbqsrc/cargo-ndk#22

Fixes #103

@tharvik tharvik self-assigned this Jul 20, 2022
@tharvik tharvik added the bug Something isn't working label Jul 20, 2022
@tharvik tharvik changed the title Fix CI github/lint-build-test: patch cargo-ndk Jul 20, 2022
@tharvik tharvik marked this pull request as ready for review July 20, 2022 11:05
@tharvik tharvik requested a review from ineiti July 20, 2022 11:06
@tharvik tharvik mentioned this pull request Jul 20, 2022
@ineiti ineiti merged commit 6bae5ca into main Aug 2, 2022
@ineiti ineiti deleted the fix-cargo-ndk branch August 2, 2022 15:08
bors bot added a commit to godot-rust/gdnative that referenced this pull request Aug 3, 2022
920: Update Android NDK (21 -> 25), workaround Rust bug r=Bromeon a=Bromeon

Newer NDKs don't work out of the box due to a Rust bug (only fixed in nightly).

See rust-lang/rust#85806 and workaround c4dt/lightarti-rest#104.

Co-authored-by: Jan Haller <bromeon@gmail.com>
KarimHamidou added a commit to KarimHamidou/godot-rust that referenced this pull request Feb 6, 2023
920: Update Android NDK (21 -> 25), workaround Rust bug r=Bromeon a=Bromeon

Newer NDKs don't work out of the box due to a Rust bug (only fixed in nightly).

See rust-lang/rust#85806 and workaround c4dt/lightarti-rest#104.

Co-authored-by: Jan Haller <bromeon@gmail.com>
GuilhermeOrceziae added a commit to GuilhermeOrceziae/godot-rust that referenced this pull request Feb 9, 2023
920: Update Android NDK (21 -> 25), workaround Rust bug r=Bromeon a=Bromeon

Newer NDKs don't work out of the box due to a Rust bug (only fixed in nightly).

See rust-lang/rust#85806 and workaround c4dt/lightarti-rest#104.

Co-authored-by: Jan Haller <bromeon@gmail.com>
hesuteia added a commit to hesuteia/godot-rust that referenced this pull request Feb 11, 2023
920: Update Android NDK (21 -> 25), workaround Rust bug r=Bromeon a=Bromeon

Newer NDKs don't work out of the box due to a Rust bug (only fixed in nightly).

See rust-lang/rust#85806 and workaround c4dt/lightarti-rest#104.

Co-authored-by: Jan Haller <bromeon@gmail.com>
ecobiubiu added a commit to ecobiubiu/open-rust that referenced this pull request Mar 30, 2023
920: Update Android NDK (21 -> 25), workaround Rust bug r=Bromeon a=Bromeon

Newer NDKs don't work out of the box due to a Rust bug (only fixed in nightly).

See rust-lang/rust#85806 and workaround c4dt/lightarti-rest#104.

Co-authored-by: Jan Haller <bromeon@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Get cargo ndk run again
2 participants