No interpolation for non-continuous fields #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some forecast fields are non-continuous, i.e. do not contain valid data for each forecast time point. Instead they just contain "-". Number.parseFloat() will parse that as NaN, causing the interpolation to fail and return NaN as well. Except for files that are fully in the future, nothing but NaN will be returned, because interpolation will always fail. With this fix, the node first checks the previous forecast for NaN and only interpolates if it's a valid number. Resulting behavior: - Both values are numbers: Normal interpolation. - First value is NaN: Take second value without interpolation. Obviously, if the second the value is NaN, too, the result will still be NaN. - Second value is NaN: Result is also NaN.
|
Merged this into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #12
Some forecast fields are non-continuous, i.e. do not contain valid data for each forecast time point.
Instead they just contain "-".
Number.parseFloat() will parse that as NaN, causing the interpolation to fail and return NaN as well.
Except for files that are fully in the future, nothing but NaN will be returned, because interpolation will always fail.
With this fix, the node first checks the previous forecast for NaN and only interpolates if it's a valid number.
Resulting behavior:
Obviously, if the second the value is NaN, too, the result will still be NaN.