Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for required value is now validates emptiness of next argument #4

Merged
merged 2 commits into from
Jul 17, 2013
Merged

Check for required value is now validates emptiness of next argument #4

merged 2 commits into from
Jul 17, 2013

Conversation

dlussky
Copy link
Contributor

@dlussky dlussky commented Jul 17, 2013

Hi. There was an issue with checking required value:

  1. Write in your php script $GetOptionKit->add('t|test:', 'required value');
  2. Run it as follows:
    ./script --test
  3. There is no exception on parsing args.
  4. There, I fixed it!)

P.S. If I've misunderstood concept of 'option requires a value.', I'm sorry.

@c9s
Copy link
Owner

c9s commented Jul 17, 2013

Hi @dlussky Thanks for sending this pull request!

c9s added a commit that referenced this pull request Jul 17, 2013
Check for required value is now validates emptiness of next argument
@c9s c9s merged commit e3162b4 into c9s:master Jul 17, 2013
@dlussky
Copy link
Contributor Author

dlussky commented Jul 18, 2013

You are welcome!
Can you please make a new version out of this, so I can use strict version number in my composer.json?

Thank you for this lib, by the way. I like the flexibility)

@c9s
Copy link
Owner

c9s commented Jul 18, 2013

Hi @dlussky

No problem. Version 1.2.4 was released, please check.

Happy Hacking
Pedro

@dlussky
Copy link
Contributor Author

dlussky commented Jul 18, 2013

Thanks!)
But I need one more favor)) Could you please also update your package here? https://packagist.org/packages/c9s/GetOptionKit
I would be completely happy))

@c9s
Copy link
Owner

c9s commented Jul 18, 2013

Hi! It's updated now. :)
On Jul 18, 2013, at 8:51 PM, Kirill Dlussky notifications@github.com wrote:

Thanks!)
But I need one more favor)) Could you please also update your package here? https://packagist.org/packages/c9s/GetOptionKit
I would be completely happy))


Reply to this email directly or view it on GitHub.

@dlussky
Copy link
Contributor Author

dlussky commented Jul 18, 2013

Awesome! Thank you very much!)

@c9s
Copy link
Owner

c9s commented Jul 18, 2013

No problem, my pleasure.

Kirill Dlussky 於 2013年7月18日星期四寫道:

Awesome! Thank you very much!)


Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-21180919
.

Best Regards,

Yo-An Lin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants