Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/hhllstop #1121

Merged
merged 11 commits into from
Apr 18, 2023
Merged

Feature/hhllstop #1121

merged 11 commits into from
Apr 18, 2023

Conversation

andycheng123
Copy link
Collaborator

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @andycheng123, This pull request may get 425 BBG.

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #1121 (d4e4242) into main (c3ee89c) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

❗ Current head d4e4242 differs from pull request most recent head c3318cb. Consider uploading reports for the commit c3318cb to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1121      +/-   ##
==========================================
- Coverage   19.89%   19.80%   -0.09%     
==========================================
  Files         434      447      +13     
  Lines       33951    34322     +371     
==========================================
+ Hits         6754     6797      +43     
- Misses      26649    26980     +331     
+ Partials      548      545       -3     
Impacted Files Coverage Δ
pkg/bbgo/exit.go 1.16% <0.00%> (-0.11%) ⬇️
pkg/bbgo/exit_hh_ll_stop.go 0.00% <0.00%> (ø)

... and 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52b2ffe...c3318cb. Read the comment docs.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 429 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 459 BBG

@andycheng123 andycheng123 changed the title WIP: Feature/hhllstop Feature/hhllstop Apr 11, 2023

// Subscribe required k-line stream
func (s *HigherHighLowerLowStop) Subscribe(session *ExchangeSession) {
// use 1m kline to handle roi stop
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update comment?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 473 BBG

@andycheng123 andycheng123 merged commit 68f54c0 into c9s:main Apr 18, 2023
@bbgokarma-bot
Copy link

Hi @andycheng123,

Well done! 488 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xb1d5178a191cac7bf63b900cfdf1d6c3fc718f77851d53145bc1bea217cf809d

Thank you for your contribution!

@andycheng123 andycheng123 deleted the feature/hhllstop branch April 18, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants