Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new circuitbreaker in common strategy #1749

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

r03921081
Copy link

@r03921081 r03921081 commented Sep 18, 2024

Strategy.RiskController.circuitBreakRiskControl now uses the new circuitbreaker: circuitbreaker.BasicCircuitBreaker

@bbgokarma-bot
Copy link

Hi @r03921081,

This is KarmaBot, and we reward your contributions with tokens sent directly to your wallet to support development.

This pull request may get 207 BBG.

To receive BBG tokens, please provide your Polygon (can be Ethereum) address as an issue comment in this pull request, following this format:

polygon:0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B

Once this pull request is merged, your BBG tokens will be transferred to your wallet.

--
If you're interested in our project, feel free to join our Telegram group https://t.me/bbgo_intl

Best,
KarmaBot

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Andy Liao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 24.11%. Comparing base (271eafa) to head (7137343).
Report is 69 commits behind head on main.

Files with missing lines Patch % Lines
pkg/strategy/common/strategy.go 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1749      +/-   ##
==========================================
- Coverage   24.11%   24.11%   -0.01%     
==========================================
  Files         615      617       +2     
  Lines       37544    37567      +23     
==========================================
+ Hits         9055     9059       +4     
- Misses      27691    27710      +19     
  Partials      798      798              
Files with missing lines Coverage Δ
pkg/strategy/common/strategy.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37106c3...7137343. Read the comment docs.

@c9s c9s merged commit 113695e into c9s:main Oct 6, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants