Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: improve: bollmaker: position stack #641

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

WIP: improve: bollmaker: position stack #641

wants to merge 5 commits into from

Conversation

austin362667
Copy link
Collaborator

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @austin362667, This pull request may get 1473 BBG.

@austin362667 austin362667 requested review from c9s and zenixls2 and removed request for c9s May 30, 2022 07:23
@austin362667 austin362667 force-pushed the feature/bollmaker/position-stack branch from 84130c5 to 54d60b9 Compare May 30, 2022 07:24
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 458 BBG

c9s
c9s reviewed May 30, 2022
View reviewed changes
config/bollmaker.yaml Outdated Show resolved Hide resolved
c9s
c9s reviewed May 30, 2022
View reviewed changes
pkg/types/position.go Outdated Show resolved Hide resolved
c9s
c9s reviewed May 30, 2022
View reviewed changes
pkg/types/position.go Outdated Show resolved Hide resolved
c9s
c9s reviewed May 30, 2022
View reviewed changes
pkg/types/position.go Outdated Show resolved Hide resolved
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 407 BBG

@austin362667 austin362667 requested a review from c9s May 30, 2022 10:25
@c9s c9s added this to the next milestone Jun 8, 2022
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenixls2 zenixls2 Awaiting requested review from zenixls2

@c9s c9s Awaiting requested review from c9s

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2023 Q1
Development

Successfully merging this pull request may close these issues.
4 participants
@austin362667 @bbgokarma-bot @CLAassistant @c9s