Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused memory pool and memory code #147

Merged
merged 2 commits into from
Nov 5, 2021
Merged

Remove unused memory pool and memory code #147

merged 2 commits into from
Nov 5, 2021

Conversation

bjosv
Copy link
Collaborator

@bjosv bjosv commented Nov 3, 2021

There is a lot of code in memory.h and .c that currently is unused.
This PR removes the unused memory pool and its internal code.

@coveralls
Copy link

coveralls commented Nov 3, 2021 •
edited
Loading

Coverage Status

Coverage increased (+19.3%) to 90.214% when pulling bf11f8e on Nordix:memory-pool-cleanups into e533bae on c9s:2.0.

@bjosv
Copy link
Collaborator Author

bjosv commented Nov 3, 2021 •
edited
Loading

This code might be here for a reason unknown to me. In that case I would be happy to be enlightened.

zuiderkwast
zuiderkwast approved these changes Nov 4, 2021
View reviewed changes
Copy link

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c9s c9s merged commit 90450de into c9s:2.0 Nov 5, 2021
@c9s
Copy link
Owner

c9s commented Nov 5, 2021

awesome

@bjosv bjosv deleted the memory-pool-cleanups branch November 5, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zuiderkwast zuiderkwast zuiderkwast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bjosv @coveralls @c9s @zuiderkwast