-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running valgrind in a different build in order to detect memory leaks. #31
Conversation
Looks nice! |
But travis ci build failed |
Because valgrind actually found an error :) |
Can you pull this so it will be part of the build process? |
Hi! can you rebase this PR ? so we may know the key point of the failure. |
For some reason I can't push. Just merge this and see what happens in the next build. |
Well, I guess you need to push + |
I did. |
ok it's building https://travis-ci.org/c9s/r3/builds/25682078 |
since like there is a missing config for it?
|
https://travis-ci.org/c9s/r3/jobs/25683096 there is no leaks now, but it's failed. |
There is a error: ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 2 from 2) |
See?
|
yeah because the shared library: libr3 can't be found. so there is an error about |
Great, let me merge this. |
Running valgrind in a different build in order to detect memory leaks.
No description provided.