New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Clinical Attributes to Mutations Tab in Results View #3793
Add Clinical Attributes to Mutations Tab in Results View #3793
Conversation
17206ca
to
bd7bb36
Compare
src/shared/components/columnVisibilityControls/ColumnVisibilityControls.tsx
Outdated
Show resolved
Hide resolved
src/shared/components/columnVisibilityControls/ColumnVisibilityControls.tsx
Outdated
Show resolved
Hide resolved
725c10d
to
2c4baff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the refactoring! Added a minor comment about the custom dropdown component.
4b0b8a8
to
cd3395f
Compare
9c310d6
to
6cd6c81
Compare
@Rajat-Sirohi Thanks for implementing this! Is it correct that the filtering with the search field doesn't currently work? E.g.: |
@inodb Currently, since clinical attribute datatypes are not always strings, I have not implemented any filter for them. If you like, I can attach a filter for those columns with string datatypes? |
@Rajat-Sirohi if it's easy to do it for all string types it would be a nice enhancement |
@Rajat-Sirohi i know you'll be adding filtering per column as well in the future, which would address it as well. So only if it's easy to add (CC @Luke-Sikina thoughts?) |
I think Nikki mentioned that he wanted to keep the global filtering, so we should definitely make it work for the string typed columns |
We need to make sure that search is functional for not-yet-loaded clinical data. I can't remember the current behavior for lazy loaded columns, but it may not work as desired by default. |
@onursumer Thanks for the heads-up! Luckily, it looks like filtering via search automatically traverses all the pages in the table, which activates the respective fetch calls for the currently visible lazy loaded columns. So no need to change anything. |
6cd6c81
to
dbf85d8
Compare
994073b
to
014f9c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! Just added a few more minor comments.
src/pages/studyView/addChartButton/addChartByType/AddChartByType.tsx
Outdated
Show resolved
Hide resolved
bb6e2d8
to
d0107da
Compare
d0107da
to
61e2ba0
Compare
61e2ba0
to
c0be78f
Compare
Failing tests seem unrelated: https://app.circleci.com/pipelines/github/cBioPortal/cbioportal-frontend/5099/workflows/e5e694fb-7b7b-4b0b-bacd-6f2b28eb964a/jobs/103269/artifacts. Somehow the heatmaps tab started disappearing, so that's the reason why quite a few screenshots are failing |
Thanks so much @Rajat-Sirohi ! Really nice work 🥇 ! |
Fix cBioPortal/cbioportal#8657 + first two of cBioPortal/cbioportal#8716
Changes:
pages/studyView/.../AddChartByType
(only replaces drop-down menu for Mutations Tab in Results View, not all Mutation Tables)
FixedHeaderTable.tsx
Currently, neither the group comparison nor custom charts clinical attributes are included, since they need individualized methods of fetching the clinical data and testing them proves difficult without a login. This should be addressed in a later PR.
Old drop-down menu:
New drop-down menu: