Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feedback: clinical data in mutations tab #8716

Closed
tmazor opened this issue Jun 23, 2021 · 1 comment
Closed

feedback: clinical data in mutations tab #8716

tmazor opened this issue Jun 23, 2021 · 1 comment
Assignees
@Rajat-Sirohi @Luke-Sikina

Comments

@tmazor
Copy link
Contributor

tmazor commented Jun 23, 2021

This is awesome @Rajat-Sirohi !

I have just a few comments:

  1. This is super minor, but the header looks very squat
    image

compared to OncoPrint
image

or study view
image

Can you add a bit more space above/below 'Clinical' and 'Mutations'?

  1. In the Clinical Data tab in Study View, there's a tooltip with the description of the clinical data element:
    image

Could we do something similar here?

And just to put all the feedback in one place, here are @jjgao's comments from slack:

  1. Do we need a “reset to default” button? (right now we can refresh the page to reset)

  2. It would be good to remember the columns when switching genes, but that could be a separate effort as discussed on Monday.

I agree with both of those suggestions, and will just add that 3 becomes essential once we do 4. I'd be ok with 3 as a follow-up task if that makes more sense, but we should definitely do both.
This was referenced Jun 23, 2021
Open
Merged
@Rajat-Sirohi Rajat-Sirohi mentioned this issue Jul 16, 2021
Merged
@inodb
Copy link
Member

inodb commented Jul 20, 2021 •
edited

feedback has been addressed, will be released as part of cBioPortal/cbioportal-frontend#3831

@inodb inodb closed this as completed Jul 20, 2021
inodb pushed a commit to cBioPortal/cbioportal-frontend that referenced this issue Jul 23, 2021
@Rajat-Sirohi
Save Column Visibility & Add "Reset Columns" Button (#3846)
3a990bc 
Fixes cBioPortal/cbioportal#8521, 3.1 Store user settings and 3.2 Add "reset to default" button based on app configuration in cBioPortal/cbioportal#8711, points 3 & 4 in cBioPortal/cbioportal#8716.

Changes:

Remembers active column selection when switching genes in Results View Mutation Table
Adds "Reset Columns" button which resets the visible columns back to their initial configuration (i.e., according to the visible attribute in the column definition). Note, this button is only shown when the current column selection is different from the default configuration. (Feedback on its design is appreciated.)
Fixes bug in cbioportal-frontend-commons where user-selection was prevented when passing columnVisibility prop to LazyMobXTable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rajat-Sirohi Rajat-Sirohi

@Luke-Sikina Luke-Sikina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@inodb @tmazor @Rajat-Sirohi @Luke-Sikina