Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile frontend performance of oncoprint #4017

Closed
jjgao opened this issue Mar 22, 2018 · 1 comment
Closed

profile frontend performance of oncoprint #4017

jjgao opened this issue Mar 22, 2018 · 1 comment

Comments

@jjgao
Copy link
Member

jjgao commented Mar 22, 2018

  • API loading time
  • Are we loading unnecessary data?
  • Frontend processing
  • Rendering
@adamabeshouse
Copy link
Contributor

adamabeshouse commented Mar 23, 2018

as far as oncoprint rendering, it seems basically 100% of javascript time spent sorting the tracks.

I've logged an issue to oncoprintjs that I think will help address that - cBioPortal/oncoprintjs#66 to allow radix sort which is O(n) instead of the costly comparator-based sort which is O(nlogn) (which will also make it possible to make some other optimizations). For mskimpact this could mean a 10+ times speedup .. hopefully..

@jjgao jjgao closed this as completed May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants