Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings for multiple vs single OncoKB icon in annotation column #8710

Closed
2 of 3 tasks
leexgh opened this issue Jun 22, 2021 · 4 comments
Closed
2 of 3 tasks

Settings for multiple vs single OncoKB icon in annotation column #8710

leexgh opened this issue Jun 22, 2021 · 4 comments
Assignees

Comments

@leexgh
Copy link
Member

leexgh commented Jun 22, 2021

We want to have a setting for choosing between single or multiple oncokb icons:

  • at the app level we want to control the default column visibility maybe something like show.default_annotation_columns="oncokb_drug,oncokb_diagnostics,etc..". That way we can enable the mutiple oncokb icons on the MSK portal to have it be consistent with the clinical PDF report that shows the same icons. On the public portal we can show a single item
  • a user should be able to choose themselves what columns to show (e.g. only one oncokb icon or more)
  • ideally, a user could persist their choice between sessions (either thru localStorage or session-service) by clicking on some button that indicates "make current column visibility my default" and e.g. "reset to default column visibility". Maybe we can use a similar UX flow for study view (where it also might be nice to opt in to persist the current chart selection rather than always saving it as we do now)

Note: there might be some overlap with other tickets here in terms of saving user settings, so make sure to avoid duplicate work

@leexgh leexgh changed the title Add user setting for multiple vs single OncoKB icon in annotation column Add settings for multiple vs single OncoKB icon in annotation column Jun 22, 2021
@leexgh leexgh changed the title Add settings for multiple vs single OncoKB icon in annotation column Settings for multiple vs single OncoKB icon in annotation column Jun 22, 2021
@stale
Copy link

stale bot commented Sep 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 21, 2021
@tmazor
Copy link
Contributor

tmazor commented Sep 22, 2021

@jjgao what's the timeline for going back to a single icon for oncokb? Does it require this settings feature to be developed first, or can we go back to a single icon and then add these setting later?

@stale stale bot removed the stale label Sep 22, 2021
@jjgao
Copy link
Member

jjgao commented Oct 17, 2021

@zhx828 @leexgh let's prioritize this one.

@inodb
Copy link
Member

inodb commented Jan 10, 2022

Let's leave the first item here undone until someone requests this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants