-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mutations table improvements #8711
Labels
Comments
This was referenced Jul 1, 2021
Merged
inodb
pushed a commit
to cBioPortal/cbioportal-frontend
that referenced
this issue
Jul 23, 2021
Fixes cBioPortal/cbioportal#8521, 3.1 Store user settings and 3.2 Add "reset to default" button based on app configuration in cBioPortal/cbioportal#8711, points 3 & 4 in cBioPortal/cbioportal#8716. Changes: Remembers active column selection when switching genes in Results View Mutation Table Adds "Reset Columns" button which resets the visible columns back to their initial configuration (i.e., according to the visible attribute in the column definition). Note, this button is only shown when the current column selection is different from the default configuration. (Feedback on its design is appreciated.) Fixes bug in cbioportal-frontend-commons where user-selection was prevented when passing columnVisibility prop to LazyMobXTable
inodb
pushed a commit
to cBioPortal/cbioportal-frontend
that referenced
this issue
Jul 23, 2021
Fix cBioPortal/cbioportal#8713 and `2.2 Filtering per column` in cBioPortal/cbioportal#8711 Changes: - Added two types of data filters, `NumericalFilter` and `CategoricalFilter`, which are attached to columns in the results view mutation table - Numerical filters consist of a range slider with two handles and input boxes - Categorical filters consist of search and multi-select functionality - Multiple column filters can be active simultaneously, and they work in conjunction with the search filter in the top-right (i.e. only those rows which match ALL active filters will be shown) - Hover cursor over column in order to show filter icon (if it's applicable for that column)
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related tickets and mockup
Improvements
1. Annotation column
1.1 Annotation column header
1.2 Settings for multiple or single oncokb icons
1.3 Settings for show or hide annotation sources (superseded by 2.4)
1.4 Integration oncokb icon
1.5 Grouped columns for the annotation column (superseded by 2.4)
1.6 Improve sorting (superseded by 2.4)
2. Column menu
2.1 Add Clinical Attributes to Mutations Column Menu
2.2 Filtering per column
2.3 Add column number in menu button and tabs
2.4 Grouped mutation columns
3. Store settings
3.1 Store user settings
Keep track of what columns were selected
3.2 Add "reset to default" button based on app configuration (related to 3.1)
The text was updated successfully, but these errors were encountered: