-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config param to customize single vs multi oncokb icons #9145
Conversation
11f10cd
to
bf31b2b
Compare
bf31b2b
to
90dd521
Compare
# Enable merging of OncoKB icons | ||
oncokb.merge_icons=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it's better to comment out this one. The default of true
should be done in code rather than in the properties file. Issue is that when someone upgrades their cbioportal version they wouldn't have this property set in their existing properties file
@@ -45,6 +45,7 @@ | |||
"oncoprint.hide_vus.default", | |||
"mycancergenome.show", | |||
"oncokb.public_api.url", | |||
"oncokb.merge_icons", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe merge_icons_by_default
? If we ever would want to give the option to not split the icons at all thru config then this is more explicit
90dd521
to
3dee607
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Related to #8710
Checks